Implement per-room user UI + speaking #84
No reviewers
Labels
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
puregarlic/microclimate!84
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue/47-channel-user-info"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #47.
5c8fc251f4to0390c0927c380a5e6abato8263a0ed288263a0ed28toc37e2a3b31We tested the changes functionally and it looked good, still have to look at the code though.
LGTM past the two things
@ -12,11 +12,11 @@ WORKDIR /usr/app/microclimate/serverARG DATABASE_URL=sqlite:data.db?mode=rwcRUN sqlx migrate runRUN cargo build --bin server --release --lockedDo we want this back?
@ -3,2 +9,3 @@import { IconChartBar } from "@tabler/icons-react";export default function Home() {function formatBytes(bytes: number): string {Could this be in utils?
+1 on this
Some feedback. I know a lot of the existing imports are inconsistent, but let's try to use
~/imports for new code. It can be sort of tough to get Claude to follow, so you'll have to be vigilant.@ -13,3 +13,3 @@ARG DATABASE_URL=sqlite:data.db?mode=rwcRUN sqlx migrate runRUN cargo build --bin server --release --lockedRUN cargo build --bin server --releaseBetter fix this
@ -17,3 +17,3 @@FROM debian:trixie-slimRUN apt-get update && apt-get install openssl ca-certificates -yRUN apt-get update && apt-get install openssl -yFix this too, don’t let ‘em go away
@ -0,0 +40,4 @@<spanclassName={cn("absolute right-0 bottom-0 rounded-full ring-background",dotSize === "sm" ? "size-2 ring-1" : "size-3 ring-2",I would recommend setting up
dotSizelike the components from@shadcn/ui, using thecvasetup. That should make this cleaner.@ -1,5 +1,6 @@import { invoke } from "@tauri-apps/api/core";import { useMutation, useQuery } from "@tanstack/react-query";import { fetchChannels } from "../../lib/utils.ts";libandhooksimports (and generally everything except stuff in the same directory) should be imported using the~/prefix instead of../../.@ -0,0 +12,4 @@quality?: string;}export function ParticipantSubButton({ did, isSpeaking, quality }: ParticipantSubButtonProps) {This component needs to handle the error condition
@ -0,0 +12,4 @@queryClient.setQueryData<string[]>(QUERY_KEY, event.payload);});const left = listen("channel_left", () => {Can we name this event to be
channel_exitedor something like that. I keep thinking this is left audio channel-specific and it's killing my vibe@ -0,0 +26,4 @@queryKey: QUERY_KEY,queryFn: () => [],initialData: [],staleTime: Infinity,Bold
@ -0,0 +28,4 @@});return () => {quality.then((fn) => fn());You probably want to wrap these functions in a
Promise.all. Since you're not catching them, we could potentially run into a scenario where one throws before the other. You want to await them both and catch their errors.@ -0,0 +15,4 @@useEffect(() => {const unlistenPromise = listen<RoomStats>("room_stats", (event) => {setStats(event.payload);Is there a reason to wrap this in state instead of the query client?
c37e2a3b31to764d09a696764d09a696toe0b8588efd